Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I assume this has never been tested. #4

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

drtconway
Copy link
Contributor

No description provided.

@illusional illusional merged commit e6a35d2 into PMCC-BioinformaticsCore:master Jun 4, 2020
@illusional
Copy link
Member

illusional commented Jun 4, 2020

Thanks for the PR @drtconway.

In an earlier version it was flipped, and looks like two errors cancelled each other out during testing, when I corrected it 42caaa9 it looks like I've flipped it back to incorrect.

For transparency, we're currently upgrading both germline and somatic pipelines, with more QC and other tools to bring them more in-line with what is expected - and to use the latest Janis features.

We're also working on better release and testing processes to catch errors like these, because they're not acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants