Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make multiphase modeling easier #687

Closed
jgostick opened this issue Mar 21, 2017 · 1 comment
Closed

Make multiphase modeling easier #687

jgostick opened this issue Mar 21, 2017 · 1 comment
Milestone

Comments

@jgostick
Copy link
Member

This has been bugging me for a while, and now I'm doing to multiphase calcs, so I will try to capture the changes we need:

  1. Perhaps Phase objects should have 'occupancy' initialized by default? The multiphase conductance models need these to run (but don't care if they are all zeros).
  2. The occupancy of the first phase could be all 1's, but then all subsequent phases be 0's
  3. As the occupancy of a Phase changes, the other phases could be automatically adjusted for consistency
  4. Item 3 might not make sense in simulation with Phases that don't interact (like if there is a 'solid' phase), so perhaps this is a good junction to start thinking about 'mixture' objects again?
@jgostick jgostick added this to the V2.0 milestone May 8, 2017
@jgostick jgostick modified the milestones: V2.0, V2+, V2.1 Jul 9, 2018
@jgostick
Copy link
Member Author

We have added a MultiPhase class that does this...sort of. I will close this on the basis that we'll be fleshing out the multiphase class over the next little while and the issue should be more clearly understood then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant