-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoints, conduit_lengths and pore.area from network models #99
Conversation
@jgostick I added openpnm to the requirments of porespy and now this pr is failing on python 3.5. This was done to make use of the endpoints and conduit_lengths models in openpnm. |
|
As you can see the results aren't perfect but probably good enough for now. @szbrooks has an idea on how to get better results I believe |
Codecov Report
@@ Coverage Diff @@
## dev #99 +/- ##
==========================================
- Coverage 90.62% 90.49% -0.14%
==========================================
Files 17 17
Lines 1654 1672 +18
==========================================
+ Hits 1499 1513 +14
- Misses 155 159 +4 |
@jgostick I took 3.5 out of travis - is there anywhere else it needs to be updated for the package? |
Shall I merge? |
I'm sure there will be conflicts. I can do it |
@jgostick that lat pr just went straight into master! |
Screw it then, Just merge the other two into dev and sort out the mess in dev |
Oh crap! I didn't even check that, just assumed it was setup correctly. I'll try to fix. |
ok, I fixed the PR and undid the commits to master. I'll try to resolve the conflicts, since I created most of them. |
No description provided.