Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read version from nimble file #60

Merged
merged 9 commits into from Mar 28, 2023
Merged

Conversation

daniel-j
Copy link
Contributor

@daniel-j daniel-j commented Mar 6, 2023

To avoid having to update futhark.nim when version changes. Uses nimble dump.

@PMunch
Copy link
Owner

PMunch commented Mar 7, 2023

I tried systems like this, but they ended up failing when I did nimble upgrade. I think that was using a slightly different system though where both the nimble file and futhark.nim file would import a version.nim file and grab the version from there, so this approach might work. You could also use nimbleutils to simplify the call a bit.

@daniel-j daniel-j marked this pull request as ready for review March 7, 2023 12:07
@PMunch
Copy link
Owner

PMunch commented Mar 10, 2023

Can this be made to use https://github.com/PMunch/nimbleutils instead? That way any special cases for Nimble handling can just live in that repo

@daniel-j
Copy link
Contributor Author

I think nimbleutils needs some tweaking, all the fields of NimblePkg are hidden for example. And the nimbleDump command doesn't use quoteShell. Why isn't it parsing the json output of nimble dump?

@PMunch
Copy link
Owner

PMunch commented Mar 12, 2023

Oh indeed, I just pushed a new version which fixes these problems. The reason why it isn't parsing the JSON output of Nimble dump is mostly because I didn't know it existed when I wrote that package. But the result is the same anyways so it doesn't matter terribly much, if anything this might even be a bit quicker since it's parsing it directly into the object and not into an intermediary format.

@daniel-j
Copy link
Contributor Author

Updated to use latest nimbleutils version

@PMunch PMunch merged commit 2c69eec into PMunch:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants