Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider building static versioned docker images #88

Open
sgosline opened this issue Jan 29, 2024 · 7 comments
Open

Consider building static versioned docker images #88

sgosline opened this issue Jan 29, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@sgosline
Copy link
Member

Currently our continuous integration has each docker image being built on the fly, which makes it challenging to ensure that the data and packages being used are stable. We can instead build each docker image and store it on docker hub, then just pull from docker hub to build data package.

@sgosline sgosline added the enhancement New feature or request label Jan 29, 2024
@jjacobson95
Copy link
Collaborator

Not a bad idea, this should make our pipeline for stable. Do you know if any of the packages we use to pull data are linked to specific versions of data? For example, is an older version of the cptac package linked to an older version of their data?

@sgosline
Copy link
Member Author

The package seems to pull from zenodo. But it breaks frequently.

@jjacobson95
Copy link
Collaborator

This would speed up the CI quite a bit - particularly the drug generation portion.

@jjacobson95
Copy link
Collaborator

I'll do this. Should these be linked to a specific account or should I use my own?

@jjacobson95
Copy link
Collaborator

Not versioned, but DockerHub build/push/pull added to CI for efficiency reasons. This will be in PR #101.

@jjacobson95
Copy link
Collaborator

Docker images are now built at the beginning of the CI pipeline. These can be a separate workflow once they no longer need to be updated so frequently.

@sgosline
Copy link
Member Author

sgosline commented Jul 9, 2024

Created new build.yml file to just build docker files, now just need to figure out how to version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready
Development

No branches or pull requests

2 participants