Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An example of using pounders for emittance minimization #104

Merged
merged 3 commits into from
Sep 22, 2023
Merged

An example of using pounders for emittance minimization #104

merged 3 commits into from
Sep 22, 2023

Conversation

jmlarson1
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Sep 20, 2023 •
edited

Pull Request Test Coverage Report for Build 6251602169

  • 29 of 29 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 96.725%
Totals Coverage Status
Change from base Build 6227318629: 0.1%
Covered Lines: 827
Relevant Lines: 855
💛 - Coveralls

nneveu
nneveu approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@nneveu nneveu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding me to review!

pounders/py/tests/Test_emittance_opt.py Outdated Show resolved Hide resolved
pounders/py/tests/Test_emittance_opt.py Outdated Show resolved Hide resolved
nneveu
nneveu approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@nneveu nneveu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the comments and min emit change!

@jmlarson1 jmlarson1 requested review from mmenickelly and removed request for mmenickelly September 20, 2023 16:50
@jmlarson1 jmlarson1 merged commit 75f804f into main Sep 22, 2023
23 checks passed
@jmlarson1 jmlarson1 deleted the feature/example_emittance branch September 22, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nneveu nneveu nneveu approved these changes

@mmenickelly mmenickelly mmenickelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmlarson1 @coveralls @nneveu @mmenickelly