Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/move xkin #83

Merged
merged 6 commits into from
Jul 11, 2023
Merged

Feature/move xkin #83

merged 6 commits into from
Jul 11, 2023

Conversation

jmlarson1
Copy link
Collaborator

Moving xkin to best point in both GOOMBAH versions.

@coveralls
Copy link

coveralls commented Jul 6, 2023 •
edited

Pull Request Test Coverage Report for Build 5510267345

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.158%
Totals Coverage Status
Change from base Build 5510051770: 0.0%
Covered Lines: 429
Relevant Lines: 556
💛 - Coveralls

mmenickelly
mmenickelly approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@mmenickelly mmenickelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing breaks on a subset of mpc_tests. I get the sense that this helps, but we should really put in more rigorous regression tests soon.

@jmlarson1 jmlarson1 merged commit a5dbd4d into main Jul 11, 2023
7 checks passed
@jmlarson1 jmlarson1 deleted the feature/move_xkin branch July 11, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmenickelly mmenickelly mmenickelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmlarson1 @coveralls @mmenickelly