Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create macros for similar assembly instructions #5

Closed
fabioperez opened this issue Aug 3, 2015 · 1 comment
Closed

Create macros for similar assembly instructions #5

fabioperez opened this issue Aug 3, 2015 · 1 comment
Assignees
@gut
Labels
task

Comments

@fabioperez
Copy link

File: ppc64-asm/asm-ppc64.h

Create macros for similar assembly instructions (like in the example below) to make the code more readable and maintainable.

Example:

void add    (const Reg64& rt, const Reg64& ra, const Reg64& rb, bool rc);   
void addc   (const Reg64& rt, const Reg64& ra, const Reg64& rb, bool rc);  
void addco  (const Reg64& rt, const Reg64& ra, const Reg64& rb, bool rc); 
void adde   (const Reg64& rt, const Reg64& ra, const Reg64& rb, bool rc);  
void addeo  (const Reg64& rt, const Reg64& ra, const Reg64& rb, bool rc);
@fabioperez fabioperez added the task label Aug 3, 2015
@gut gut self-assigned this Aug 17, 2015
@gut
Copy link

gut commented Aug 17, 2015

a899d40
All XO-Form were refactored.

@gut gut closed this as completed Aug 17, 2015
lbianc pushed a commit that referenced this issue Jun 1, 2016
@Orvid
Switch uses of <dirent.h> to <folly/portability/Dirent.h>
88c0df9 
Summary: Diff #5 of 14.

Reviewed By: mzlee

Differential Revision: D3186885

fbshipit-source-id: 1947656137cad62a019cdf687cff9913bcecde2a
lbianc pushed a commit that referenced this issue Sep 26, 2017
@igorsugak @hhvm-bot
fix UMR UB in debugger_client
41762be 
Summary:
Reported by UBSAN:
```lang=bash
001+ hphp/runtime/debugger/debugger_client.cpp:2515:7: runtime error: load of value 190, which is not a valid value for type 'bool'
002+     #0 0xa04d7ed in HPHP::Eval::DebuggerClient::saveConfig() hphp/runtime/debugger/debugger_client.cpp:2515
003+     #1 0xa02b046 in HPHP::Eval::DebuggerClient::setDebuggerClientSmallStep(bool const&) hphp/runtime/debugger/debugger_client.h:352
004+     #2 0xa02b046 in HPHP::Eval::DebuggerClient::loadConfig() hphp/runtime/debugger/debugger_client.cpp:2391
005+     #3 0xa02995f in HPHP::Eval::DebuggerClient::init(HPHP::Eval::DebuggerClientOptions const&) hphp/runtime/debugger/debugger_client.cpp:750
006+     #4 0xa015d01 in HPHP::Eval::DebuggerClient::start(HPHP::Eval::DebuggerClientOptions const&) hphp/runtime/debugger/debugger_client.cpp:783
007+     #5 0xa015d01 in HPHP::Eval::DebuggerClient::Start(HPHP::Eval::DebuggerClientOptions const&) hphp/runtime/debugger/debugger_client.cpp:399
008+     #6 0x9fe833b in HPHP::Eval::Debugger::StartClient(HPHP::Eval::DebuggerClientOptions const&) hphp/runtime/debugger/debugger.cpp:56
009+     #7 0x884b41f in HPHP::execute_program_impl(int, char**) hphp/runtime/base/program-functions.cpp:1929
010+     #8 0x883d586 in HPHP::execute_program(int, char**) hphp/runtime/base/program-functions.cpp:1200
011+     #9 0x72782e in main hphp/hhvm/main.cpp:85
012+     #10 0x7ffbeed1c857 in __libc_start_main /home/engshare/third-party2/glibc/2.23/src/glibc-2.23/csu/../csu/libc-start.c:289
013+     #11 0x724e28 in _start /home/engshare/third-party2/glibc/2.23/src/glibc-2.23/csu/../sysdeps/x86_64/start.S:118
015+ SUMMARY: UndefinedBehaviorSanitizer: invalid-bool-load hphp/runtime/debugger/debugger_client.cpp:2515:7 in

```

Reviewed By: markw65

Differential Revision: D5898634

fbshipit-source-id: 102f90ead9766b381a4dc722800ad6e7fb8a76be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gut gut

Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gut @fabioperez