Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licence for Dilithium and Kyber #488

Merged
merged 6 commits into from
Jun 11, 2023
Merged

Licence for Dilithium and Kyber #488

merged 6 commits into from
Jun 11, 2023

Conversation

vincentvbh
Copy link
Contributor

As titled.
At the beginning of each file, you will find the license information.

Manually checked properties

  • Generated Github workflow (run .github/workflows/generate_workflows.py) (new schemes)
  • No stringification macros
  • Output-parameter pointers in functions are on the left
  • Negative return values on failure of API functions (within restrictions of FO transform).
  • variable declarations at the beginning (except in for (size_t i=...)
  • Optional:
    • All integer types are of fixed size, using stdint.h types (including uint8_t instead of unsigned char)
    • Integers used for indexing are of size size_t

@mkannwischer
Copy link
Contributor

Can we merge this or do we need to change it somehow? I would not know how to do it any better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants