Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dilithium Aarch64 duplicate consistency and asm #501

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix Dilithium Aarch64 duplicate consistency and asm #501

merged 1 commit into from
Aug 28, 2023

Conversation

thomwiggers
Copy link
Member

@thomwiggers
Fix Dilithium Aarch64 duplicate consistency and asm
a04200b 
* ASM symbols were named differently than their header files (#495)
* Duplicate consistency did not work correctly due to incorrect
  capitalization of symbol names
@thomwiggers
Copy link
Member Author

Will need to test this on actual ARM

@thomwiggers thomwiggers marked this pull request as ready for review August 28, 2023 14:09
@thomwiggers thomwiggers merged commit 2888153 into master Aug 28, 2023
33 of 45 checks passed
@thomwiggers thomwiggers deleted the fix-Dilithum-symbols-and-duplicate-consistency branch August 28, 2023 14:09
@thomwiggers
Copy link
Member Author

yolo-merging this as I hope this will get fixed and tested by the update to the draft standard

@SWilson4 SWilson4 mentioned this pull request Sep 12, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@thomwiggers