Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] allow pr2.urdf.xacro to accept customized calibration values #285

Merged
merged 4 commits into from Oct 5, 2020

Conversation

Smilels
Copy link
Contributor

@Smilels Smilels commented Sep 14, 2020

  1. add calibration parameters in separate xacro files
  2. in urdf/shoulder_v0/shoulder.urdf.xacro, we detect if parameters shoulder_pan_calibi, upper_arm_roll_calib equal to 0.
    If equal, use the default values. If not equal, use the passing values.

sli added 2 commits September 14, 2020 15:30
1. add calibration parameters in separate xacro files
2. in urdf/shoulder_v0/shoulder.urdf.xacro,
we detect if parameters shoulder_pan_calibi, upper_arm_roll_calib equal to 0.
If equal, use the default values.
If not equal, use the passing values.
@v4hn v4hn changed the title allow pr2.urdf.xacro to accept customized calibration values [WIP] allow pr2.urdf.xacro to accept customized calibration values Sep 14, 2020
Copy link
Member

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-okada Please review and merge. I made sure this change is backward compatible and it provides a useful extension to easily set calibration values from external data (e.g. a yaml file). Long(er) story below.

Last week we noticed once again how much work it can be to update a calibrated PR2 urdf when the xacro files change. To finally resolve this after all this time, we now store the calibration tags in a yaml file and instantiate the macros to use the values instead of loading a generated and calibrated urdf.

In theory there is already another mechanism for this in the xacro files, but we decided to ignore it because

Thanks for iterating over this with me @Smilels .

@v4hn v4hn merged commit 60d53a2 into PR2:melodic-devel Oct 5, 2020
@v4hn
Copy link
Member

v4hn commented Oct 5, 2020

We use this change on our system and to the best of my knowledge this is fully backward-compatible.
If anyone finds problems with this, please report them here and we can deal with them right away.

@v4hn v4hn mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants