-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for compile with gazebo 9 #143
Conversation
Looks good to me as long as you create a new branch `melodic-devel` for it.
|
I'm actually not able to create branches, so I cannot. However, if you're willing to create the branch, I can update the pull request. |
@davefeilseifer have you managed to successfully run a simulation using Melodic? Just today I did the same fixes as yours. However I met other issues when starting simulation. In particular I got error about wrong argument when spawning model. Haven't looked deep into it because there may be plenty of other bugs and I hope that someone have already handled it. |
I haven't checked for runtime errors, just resolved the compile errors. I don't know this package so well, so I'm not likely to dig too deep into this in the near future. |
@davefeilseifer I just did that and retargeted the request. Thank you for the patch. @nameofuser1 If you found errors with melodic (I'm rather convinced there are some new ones aside from the API change here), please submit a fix for them! |
thanks, I have cherry-picked this PR to kinetic, with `#if GAZEBO_MAJER_VERSION >=8' switch, so that we still can keep one source tree for working ROS_DISTROs, ( otherwise, we have to cherrypick from one to another every updates) |
@nameofuser1 I think you have encountered |
kinetic-devel version of pr2_simulator is not compatible with gazebo version used with 18.04/melodic due to use of deprecated functions. These commits fix that problem.