Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for compile with gazebo 9 #143

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Conversation

davefeilseifer
Copy link
Contributor

kinetic-devel version of pr2_simulator is not compatible with gazebo version used with 18.04/melodic due to use of deprecated functions. These commits fix that problem.

@v4hn
Copy link
Member

v4hn commented Apr 1, 2019 via email

@davefeilseifer
Copy link
Contributor Author

davefeilseifer commented Apr 1, 2019

I'm actually not able to create branches, so I cannot. However, if you're willing to create the branch, I can update the pull request.

@nameofuser1
Copy link

nameofuser1 commented Apr 3, 2019

@davefeilseifer have you managed to successfully run a simulation using Melodic?

Just today I did the same fixes as yours. However I met other issues when starting simulation. In particular I got error about wrong argument when spawning model. Haven't looked deep into it because there may be plenty of other bugs and I hope that someone have already handled it.

@davefeilseifer
Copy link
Contributor Author

I haven't checked for runtime errors, just resolved the compile errors. I don't know this package so well, so I'm not likely to dig too deep into this in the near future.

@v4hn v4hn changed the base branch from kinetic-devel to melodic-devel April 5, 2019 15:51
@v4hn v4hn merged commit 779da3a into PR2:melodic-devel Apr 5, 2019
@v4hn
Copy link
Member

v4hn commented Apr 5, 2019

I'm actually not able to create branches, so I cannot. However, if you're willing to create the branch, I can update the pull request.

@davefeilseifer I just did that and retargeted the request. Thank you for the patch.

@nameofuser1 If you found errors with melodic (I'm rather convinced there are some new ones aside from the API change here), please submit a fix for them!

@v4hn v4hn mentioned this pull request Apr 5, 2019
k-okada pushed a commit to k-okada/pr2_simulator that referenced this pull request Apr 8, 2019
@k-okada
Copy link
Contributor

k-okada commented Apr 8, 2019

thanks, I have cherry-picked this PR to kinetic, with `#if GAZEBO_MAJER_VERSION >=8' switch, so that we still can keep one source tree for working ROS_DISTROs, ( otherwise, we have to cherrypick from one to another every updates)

@k-okada
Copy link
Contributor

k-okada commented Apr 24, 2019

@nameofuser1 I think you have encountered -ros_namespace /gazebo error. I think we fixed this by this patch ->
ea35683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants