Remove clang hacks #121
Merged
Remove clang hacks #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first instance of the clang workaround we can remove by simply dropping the need for a lambda: `std::for_each` with a capture-all lambda doesn't add anyting over a range-based for loop. In the second instance the workaround wasn't even necessary.
|
Terrific solution! Thanks for fixing this horrible mistake :D . I'm testing locally and merge afterward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first instance of the clang workaround we can remove by simply dropping the need for a lambda:
std::for_eachwith a capture-all lambda doesn't add anyting over a range-based for loop. In the second instance the workaround wasn't even necessary.Closes #118