Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nacho/sync ros wrappers #188

Merged
merged 7 commits into from
Jul 13, 2023
Merged

Nacho/sync ros wrappers #188

merged 7 commits into from
Jul 13, 2023

Conversation

nachovizzo
Copy link
Collaborator

After #171 and #163 got merged, the ros1 wrapped diverged a bit.

In this PR, I'm only modifying the source code (not the logic) such that the difference between both wrappers are minimal. This way, it should be easier to maintain both in the future.

CC @roncapat:

I only changed the sensor_msgs::msgs::msg::PointCloud2::UniquePtr since I found no difference in the implementation:

  template<typename Deleter = std::default_delete<
      sensor_msgs::msg::PointCloud2_<ContainerAllocator>>>
  using UniquePtrWithDeleter =
    std::unique_ptr<sensor_msgs::msg::PointCloud2_<ContainerAllocator>, Deleter>;

  using UniquePtr = UniquePtrWithDeleter<>;

@nachovizzo nachovizzo merged commit d15b30a into main Jul 13, 2023
18 checks passed
@nachovizzo nachovizzo deleted the nacho/sync_ros_wrappers branch July 14, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant