Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect installation hyperlink #272

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

HoKim98
Copy link
Contributor

@HoKim98 HoKim98 commented Jan 30, 2024

Hello, thanks for operating great works!

This PR fixes an incorrect link in README.md.

If a guest user clicks the link below,:

<a href="https://github.com/PRBonn/kiss-icp/edit/main/README.md#install">Install</a>

then the user has no permission to view, because it's editor mode.

If a normal user clicks the link, then the user would watch the installation markdown script, not the compiled web content.

So, this PR fixes the link from editor mode to viewer mode like the others.

Copy link
Member

@benemer benemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@nachovizzo nachovizzo merged commit f0e5128 into PRBonn:main Jan 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants