HeLiPR: Make sure chunk size is sufficient #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benemer
changed the title
|
Should I download this dataset 😂? |
nachovizzo
approved these changes
May 6, 2024
tizianoGuadagnino
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading HeLiPR data, in some sequences (for example
Roundabout02) the last chunk of data is incomplete and Kiss fails witherror: unpack_from requires a buffer of at least 999400 bytes for unpacking 25 bytes at offset 999375 (actual buffer size is 999383)This PR fixes this by ensuring we have enough data to read in the last chunk.