Skip to content
This repository has been archived by the owner on Apr 29, 2022. It is now read-only.

Fix memory leak #73

Open
dasaderi opened this issue Oct 20, 2019 · 4 comments
Open

Fix memory leak #73

dasaderi opened this issue Oct 20, 2019 · 4 comments

Comments

@dasaderi
Copy link
Member

There is a bug in the code that makes it so that sometimes when users go on it crashes.

@dasaderi
Copy link
Member Author

Not needed if we move code to Azure account (see issue #75).

@blahah
Copy link
Contributor

blahah commented Nov 14, 2019

I don't think the memory leak issue is related to the cloud provider. It will be somewere in the server code, and will happen the same on Azure.

@dasaderi dasaderi changed the title Fix memory leak on Digital Ocean Fix memory leak Nov 21, 2019
@dasaderi
Copy link
Member Author

Update after call with WinGravity:

PRE doesn’t use a session store yet so Sebastien think that’s the issue.
 Sessions are done with https://github.com/expressjs/session
in. Rapid uses Redis for the session store.


@blahah
Copy link
Contributor

blahah commented Nov 23, 2019

Very true that the default session store will leak memory, and that should be solved.

I doubt that it's the sole reason for the memory accumulation which is quite rapid: sessions are tiny and the number of users is not enough to account for it. I'd also argue that given the scale of the project, for PREreview at least, Redis is overkill. Just a simple file, leveldb or sqlite would be fine, are trivial to implement, cost nothing to run, and use a tiny fraction of the resources.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants