Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to require verified email addresses #1307

Closed
thewilkybarkid opened this issue Oct 11, 2023 · 0 comments
Closed

Make it possible to require verified email addresses #1307

thewilkybarkid opened this issue Oct 11, 2023 · 0 comments

Comments

@thewilkybarkid
Copy link
Member

No description provided.

thewilkybarkid added a commit that referenced this issue Oct 11, 2023
@thewilkybarkid
Create a page to ask the user for their email address
0335582 
This change adds a new form for the user's email address. It's a copy of the language form, so it doesn't ask for the correct details. It's placed behind a feature flag, turned off everywhere by default.

Refs #1307
erkannt added a commit that referenced this issue Oct 11, 2023
@erkannt
Make it easier to work with app.ts and the router
4c83dae 
Refs: #1307
thewilkybarkid added a commit that referenced this issue Oct 11, 2023
@thewilkybarkid
Made it easier to read by separating concerns
6abb301 
Refs #1307
erkannt added a commit that referenced this issue Oct 11, 2023
@erkannt
Make it easier to see how the environment is constructed
33a134e 
Refs: #1307
thewilkybarkid added a commit that referenced this issue Oct 11, 2023
@thewilkybarkid
Make it more obvious that the top-level environment is for configuration
2b71d0b 
Refs #1307
thewilkybarkid added a commit that referenced this issue Oct 11, 2023
@thewilkybarkid
Ask the right question
cc47cd6 
Note the email address cannot be saved.

Refs #1307, 0335582
thewilkybarkid added a commit that referenced this issue Oct 11, 2023
@thewilkybarkid
Fix form label
a462c5f 
Refs #1307, cc47cd6
thewilkybarkid added a commit that referenced this issue Oct 11, 2023
@thewilkybarkid
Ensure the email address form looks right
6560746 
Refs #1307
thewilkybarkid added a commit that referenced this issue Oct 11, 2023
@thewilkybarkid
Ensure the email address looks real
f2fce9c 
Refs #1307, https://design-system.service.gov.uk/patterns/email-addresses/#error-messages
thewilkybarkid added a commit that referenced this issue Oct 11, 2023
@thewilkybarkid
Make the email address field easier to use
c23d44f 
Refs #1307, https://design-system.service.gov.uk/patterns/email-addresses/, alphagov/govuk-design-system#2187
thewilkybarkid added a commit that referenced this issue Oct 11, 2023
@thewilkybarkid
Allow email addresses to be saved
38145ac 
Refs #1307
thewilkybarkid added a commit that referenced this issue Oct 12, 2023
@thewilkybarkid
Make it easier to see that EmailAddress is a type
fc3e4c1 
This change moves the module into a dedicated 'types' directory.

Refs #1307, a4a6af5
thewilkybarkid added a commit that referenced this issue Oct 12, 2023
@thewilkybarkid
Group more types together
4be3b10 
Refs #1307, fc3e4c1
thewilkybarkid added a commit that referenced this issue Oct 12, 2023
@thewilkybarkid
Link to the form to set your email address
2eb0d5a 
Refs #1307
thewilkybarkid added a commit that referenced this issue Oct 12, 2023
@thewilkybarkid
Name a function
a264f96 
Refs #1307
thewilkybarkid added a commit that referenced this issue Oct 12, 2023
@thewilkybarkid
Allow the PREreview to test out setting their email address
18151e5 
Refs #1307
thewilkybarkid added a commit that referenced this issue Oct 12, 2023
@thewilkybarkid
Fix tests
2eb9f07 
Refs #1307, 18151e5
thewilkybarkid added a commit that referenced this issue Oct 12, 2023
@thewilkybarkid
Make room to verify email addresses
c6cab07 
Refs #1307
thewilkybarkid added a commit that referenced this issue Oct 13, 2023
@thewilkybarkid
Make a test more deterministic
8f1f4a1 
I saw a test failure in CI where it generated a string that was a valid email address; this change naively filters out ones that look vaguely email-like. (I don't want to test the library we use for validating emails, so it doesn't need to be that precise.)

Refs #1307
thewilkybarkid added a commit that referenced this issue Oct 16, 2023
@thewilkybarkid
Make a test more deterministic
2e9e4a2 
Refs #1307, 8f1f4a1
thewilkybarkid added a commit that referenced this issue Nov 2, 2023
@thewilkybarkid
Make it clear when an email address hasn't been verified
082d35e 
Refs #1307
thewilkybarkid added a commit that referenced this issue Nov 2, 2023
@thewilkybarkid
Add a secret path to verify your email address
01bb2f3 
This change is a prerequisite to sending an email to verify an address. Note that it is guessable.

Refs #1307
thewilkybarkid added a commit that referenced this issue Nov 2, 2023
@thewilkybarkid
Make it more explicit that your email address has been verified
df12fe2 
Refs #1307, https://design-system.service.gov.uk/components/notification-banner/#reacting-to-something-the-user-has-done
thewilkybarkid added a commit that referenced this issue Nov 2, 2023
@thewilkybarkid
Update snapshots
775bd9f 
I forgot to commit them.

Refs #1307, df12fe2
thewilkybarkid added a commit that referenced this issue Nov 2, 2023
@thewilkybarkid
Make tests easier to evolve by making the cases clearer
b9db1fb 
Refs #1307
thewilkybarkid added a commit that referenced this issue Nov 2, 2023
@thewilkybarkid
Don't require already-verified emails to be reverified when they're n…
4dee305 
…ot changed

Refs #1307
thewilkybarkid added a commit that referenced this issue Nov 2, 2023
@thewilkybarkid
Create a space for adding a one-use token
95c9016 
This change makes each verification path unique; note it's still guessable, and email addresses will appear in logs.

Refs #1307
thewilkybarkid added a commit that referenced this issue Nov 2, 2023
@thewilkybarkid
Make it easier to add a verification token to unverified email addresses
9f54978 
As it's behind a feature flag, we don't need to worry about migrating old data.

Refs #1307
thewilkybarkid added a commit that referenced this issue Nov 2, 2023
@thewilkybarkid
Generate a unique verification token for every unverified email address
5459bc1 
This change is a prerequisite to making the path unguessable.

Refs #1307, 95c9016
thewilkybarkid added a commit that referenced this issue Nov 2, 2023
@thewilkybarkid
Improve type safety with a type guard
5cab7a8 
Refs #1307
thewilkybarkid added a commit that referenced this issue Nov 2, 2023
@thewilkybarkid
Make email verification paths unguessable
ba9c79d 
Refs #1307, 5459bc1
thewilkybarkid added a commit that referenced this issue Nov 3, 2023
@thewilkybarkid
Allow users to verify their email address
49097cc 
Refs #1307
thewilkybarkid added a commit that referenced this issue Nov 3, 2023
@thewilkybarkid
Fix the smoke test
c983ef9 
Refs #1307, 49097cc
thewilkybarkid added a commit that referenced this issue Nov 3, 2023
@thewilkybarkid
Let the user know that we're sending an email to verify their address
7fc8b74 
Refs #1307, 49097cc
thewilkybarkid added a commit that referenced this issue Nov 3, 2023
@thewilkybarkid
Let us know if we have problems sending an email
170cd9a 
Refs #1307
thewilkybarkid added a commit that referenced this issue Nov 3, 2023
@thewilkybarkid
Ensure the verification email looks right
b91209e 
HTML emails are notoriously hard to produce. This change adds a snapshot to check if it looks ok. This test isn't the same as ensuring it looks right inside an email client, but it's the best we can do.

I've had to change the link text as it contains a generated UUID and port number, which differ each time.

Refs #1307, https://explore.reallygoodemails.com/new-to-email-coding-heres-where-to-start-2494422f0bd4
thewilkybarkid added a commit that referenced this issue Nov 6, 2023
@thewilkybarkid
Increase the chances of the verification email looking right
7475d30 
This commit uses the MJML language to generate the email HTML.

Refs #1307, b91209e, https://mjml.io/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thewilkybarkid