Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove other reviewers #388

Closed
thewilkybarkid opened this issue Oct 14, 2022 · 0 comments
Closed

Remove other reviewers #388

thewilkybarkid opened this issue Oct 14, 2022 · 0 comments

Comments

@thewilkybarkid
Copy link
Member

No description provided.

thewilkybarkid added a commit that referenced this issue Oct 14, 2022
@thewilkybarkid
Add an empty route for a form to remove other authors from a PREreview
0bcf0a4 
Refs #388
thewilkybarkid added a commit that referenced this issue Oct 20, 2022
@thewilkybarkid
Add a form to remove an author from a PREreview
b35c1d2 
This commit adds a feature-flagged page that allows the user to remove another author from the PREreview. It's not linked.

As there's no consistent identifier in the author list, I've used their (0-indexed) position in the list.

Refs #388
thewilkybarkid added a commit that referenced this issue Oct 20, 2022
@thewilkybarkid
Add a link to remove an author
23e1f57 
Refs #388
thewilkybarkid added a commit that referenced this issue Oct 20, 2022
@thewilkybarkid
Add an empty route for a form to change authors on a PREreview
1492653 
Refs #388
thewilkybarkid added a commit that referenced this issue Oct 20, 2022
@thewilkybarkid
Add a form to change an author on a PREreview
386a508 
This commit adds a feature-flagged page that allows the user to change an author on the PREreview. It's not linked.

As there's no consistent identifier in the author list, I've used their (0-indexed) position in the list.

Refs #388, b35c1d2
thewilkybarkid added a commit that referenced this issue Oct 20, 2022
@thewilkybarkid
Add a link to change an author
2ce26a4 
Refs #388
thewilkybarkid added a commit that referenced this issue Oct 20, 2022
@thewilkybarkid
After removing the last author, reask the 'Did you write the PRErevie…
74e2f62 
…w with anyone else?' question

Rather than presenting the user with an empty list, this change directs them to the step where they either have to add a new author or say they did it alone.

Refs #388
thewilkybarkid added a commit that referenced this issue Oct 20, 2022
@thewilkybarkid
Go back to the list of other authors from the remove-an-author step
435424d 
Refs #388
thewilkybarkid added a commit that referenced this issue Oct 20, 2022
@thewilkybarkid
Go back to the list of other authors from the add-an-author step if t…
5edd175 
…here are other authors already

Refs #388
thewilkybarkid added a commit that referenced this issue Oct 21, 2022
@thewilkybarkid
Make property tests easier to read
a6b0f11 
This change uses the dedicated fast-check library for Jest, which reduces the amount of code required. The main benefit is that there's not so much indentation, so it's easier to read.

Refs #388, https://github.com/dubzzz/fast-check/tree/main/packages/jest
thewilkybarkid added a commit that referenced this issue Oct 21, 2022
@thewilkybarkid
Simplify reading the request method
ba06e67 
Refs #388
thewilkybarkid added a commit that referenced this issue Oct 24, 2022
@thewilkybarkid
Only lift a function once
8ed88c4 
Refs #388
thewilkybarkid added a commit that referenced this issue Oct 24, 2022
@thewilkybarkid
Simplify a pipe
22baca6 
Refs #388
thewilkybarkid added a commit that referenced this issue Oct 24, 2022
@thewilkybarkid
Prefer lifting functions
9aaf742 
Refs #388
thewilkybarkid added a commit that referenced this issue Oct 24, 2022
@thewilkybarkid
Treat failing to decode the session the same as there not being a ses…
cd8d4d3 
…sion

Refs #388
thewilkybarkid added a commit that referenced this issue Oct 24, 2022
@thewilkybarkid
Make error matching exhaustive
f0e81a1 
Refs #388
thewilkybarkid added a commit that referenced this issue Oct 24, 2022
@thewilkybarkid
Don't show an empty list of authors
b7bf547 
If the user somehow returns to the list of authors, this change prompts them to add an author rather than showing an empty list.

Refs #388, 74e2f62
thewilkybarkid added a commit that referenced this issue Oct 24, 2022
@thewilkybarkid
Fix the build
23a1808 
Refs #388, b7bf547
thewilkybarkid added a commit that referenced this issue Oct 26, 2022
@thewilkybarkid
Fix alignment in checked radio buttons/checkboxes
7c6fe16 
Using different responsive sizes for the border and the checked indicator led to some rounding problems. This change uses a relative size instead, which produces consistent results.

Refs #388
thewilkybarkid added a commit that referenced this issue Oct 26, 2022
@thewilkybarkid
Use built-in Jest types
abc27e1 
Refs #388, https://dev.to/kengotoda/how-to-replace-types-jest-with-jest-globals-and-jest-mock-52mb
thewilkybarkid added a commit that referenced this issue Oct 26, 2022
@thewilkybarkid
Use 'transform' for the ts-jest config
400d485 
They've deprecated the 'globals' way of setting options.

Refs #388, kulshekhar/ts-jest#3780
thewilkybarkid added a commit that referenced this issue Oct 26, 2022
@thewilkybarkid
Make property-test failures reproducible
429bb48 
Jest 29.2 added an option to set a seed, which fast-check uses, and to show it. In the event of a failure, we can rerun the tests with the same seed, making debugging non-deterministic failures far simpler.

I'm not sure why Dependabot isn't updating Jest/ts-jest to v29.

Refs #388, a6b0f11, jestjs/jest#13400, dubzzz/fast-check#3332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thewilkybarkid