Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompute pairhmm cell probs #51

Closed
wants to merge 3 commits into from

Conversation

johanneskoester
Copy link
Contributor

This PR introduces precomputed miscall probabilities into pairHMM computation. By that, we should save maybe 20 cycles in the innermost loop of the HMM. @dlaehnemann since you have the setup already, can you please create a flamegraph of this vs master branch? You can use test09 in lib.rs for that.

@dlaehnemann
Copy link
Member

dlaehnemann commented Nov 13, 2018

Here come the flamegraphs for master vs. the current head of the precompute-pairhmm-cell-probs branch. The Emission part you changed seems to have gone from almost 13% to almost 8% of cputime.

Master branch

perf record --call-graph dwarf,16384 -e cpu-clock -F 997 target/release/deps/lib-d3feb2225a97a416 test09

https://gist.github.com/dlaehnemann/054604c0d9b8ffac9dc211f4f9d4263f (to view the interactive and searchable SVG, right-click the preview in the gist and select View Image)

Precompute pairhmm cell probs

perf record --call-graph dwarf,16384 -e cpu-clock -F 997 target/release/deps/lib-d3feb2225a97a416 test09

https://gist.github.com/dlaehnemann/b452366c468a89d7fe1ef7e0f1c03e3b (to view the interactive and searchable SVG, right-click the preview in the gist and select View Image)

@johanneskoester
Copy link
Contributor Author

Thank you so much!

@johanneskoester
Copy link
Contributor Author

Closing in favor of #53, which contains the changes from this branch.

This was referenced Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants