Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] The python dep should match prql project #5

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

z3z1ma
Copy link
Contributor

@z3z1ma z3z1ma commented Jun 29, 2022

Just a quick fix for the python dependency. Poetry freaks out of python deps dont match the toml

@z3z1ma
Copy link
Contributor Author

z3z1ma commented Jun 29, 2022

I have confirmed this allows dbt-prql to be installed alongside dbt-core 1.1.1 on python 3.9
where otherwise dependency resolution was impossible. There are probably a significant number of users this will affect if not corrected simply because the dependencies are not relaxed. (happens when you do poetry init)

@max-sixty
Copy link
Member

One concern I had with unpinning it is that the internal dbt code may change such that it stops working, and it's not possible to later say "that doesn't work after 1.1.4".

But I think we can free the pin for patch versions, you make a good argument. For minor versions (i.e. 0.X), I do think it's worth testing before releasing, and I'm happy to do that at a decent cadence.

If we add tests which test against dbt-core/main, we catch upstream breaks early, then we can unpin minor versions too...

pyproject.toml Outdated Show resolved Hide resolved
@max-sixty max-sixty mentioned this pull request Jun 29, 2022
@max-sixty max-sixty merged commit 8a021dd into PRQL:main Jun 29, 2022
@max-sixty
Copy link
Member

This is released @z3z1ma . Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants