Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add binary numerical notation #3661

Merged
merged 5 commits into from Oct 11, 2023
Merged

Conversation

vanillajonathan
Copy link
Collaborator

This lets you use binary notation to express numbers so you can do:

from foo
filter bar == 0b1111000011110000

@max-sixty
Copy link
Member

Nice!

@max-sixty max-sixty enabled auto-merge (squash) October 11, 2023 20:17
@max-sixty
Copy link
Member

(would be great to have these as a line in the docs too!)

auto-merge was automatically disabled October 11, 2023 20:46

Head branch was pushed to by a user without write access

@vanillajonathan
Copy link
Collaborator Author

(would be great to have these as a line in the docs too!)

Thanks for the reminder. I added it to the docs now.

@max-sixty
Copy link
Member

Thanks! Will need a cargo insta test --accept to update the docs snapshot (also task test-rust should work)

@vanillajonathan
Copy link
Collaborator Author

Yeah, I just noticed. Fixed.

@max-sixty
Copy link
Member

Looking really good, thanks @vanillajonathan

@max-sixty max-sixty merged commit 52334f5 into PRQL:main Oct 11, 2023
33 checks passed
@vanillajonathan vanillajonathan deleted the patch-1 branch October 11, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants