Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: take n rows for MSSQL #3994

Merged
merged 7 commits into from
Dec 21, 2023
Merged

fix: take n rows for MSSQL #3994

merged 7 commits into from
Dec 21, 2023

Conversation

PrettyWood
Copy link
Collaborator

fix #2448

@PrettyWood
Copy link
Collaborator Author

There is a problem with one integration test. OFFSET 0 always needs to be specified with FETCH but can't exist by itself
I'm looking at it

@max-sixty
Copy link
Member

IIUC, one downside of FETCH is that it requires an ORDER BY clause.

We could try and add one in where it doesn't exist — e.g. ORDER BY SELECT(NULL), or we could just raise an error where one doesn't exist. Given this is MSSQL, I would not push for something maximalist...

@PrettyWood
Copy link
Collaborator Author

PrettyWood commented Dec 21, 2023 •
edited

@max-sixty thanks for the ORDER BY(SELECT NULL) trick!!

max-sixty
max-sixty approved these changes Dec 21, 2023
View reviewed changes
prqlc/prql-compiler/src/sql/gen_query.rs
nulls_first: None,
});
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👏

@PrettyWood PrettyWood merged commit b19bd80 into main Dec 21, 2023
34 checks passed
@PrettyWood PrettyWood deleted the fix/2448 branch December 21, 2023 22:07
eitsupi pushed a commit that referenced this pull request Dec 21, 2023
@PrettyWood
test(bindings): fix after merge of #3994 (updates for the sql.mssql t…
7321b67 
…arget) (#3995)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

@aljazerzen aljazerzen aljazerzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with take with MsSQL
3 participants
@PrettyWood @max-sixty @aljazerzen