Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should not use prql-compiler 0.6.0 on crates.io #101

Merged
merged 4 commits into from Mar 11, 2023
Merged

fix: should not use prql-compiler 0.6.0 on crates.io #101

merged 4 commits into from Mar 11, 2023

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Mar 11, 2023 •
edited

Fix #100

It uses chumsky 0.9.0, but chumsky 0.9.0 has a bug that causes an infinite loop.
chumsky 0.9.2 or later should be used.

All of the syntax error tests that are added by this PR fall into an endless loop if with chumsky 0.9.0.

@eitsupi eitsupi added the bug Something isn't working label Mar 11, 2023
@eitsupi eitsupi enabled auto-merge (squash) March 11, 2023 23:18
@eitsupi eitsupi disabled auto-merge March 11, 2023 23:19
@eitsupi eitsupi enabled auto-merge (squash) March 11, 2023 23:20
@eitsupi eitsupi disabled auto-merge March 11, 2023 23:22
@max-sixty
Copy link
Member

@eitsupi would you prefer if we released 0.6.1?

@max-sixty
Copy link
Member

If you ever want to do a release, you can (https://github.com/PRQL/prql/blob/main/book/src/contributing/development.md#releasing), or I'm happy to do one if that's easier for you

@eitsupi
Copy link
Member Author

eitsupi commented Mar 11, 2023

@max-sixty Thanks for taking care of this!
In order to adhere as much as possible to the standard release frequency (6 releases in 6 months) in accordance with the CRAN policy, prqlr will not be making new CRAN releases until late March.
So for now I am happy to install the unreleased version from GitHub.

R-universe is always an edge version installation, so it does not matter if prql-compiler is not released.

@eitsupi eitsupi merged commit 7ec3134 into main Mar 11, 2023
@eitsupi eitsupi deleted the fix-infinit-loop branch March 11, 2023 23:51
@eitsupi eitsupi mentioned this pull request Mar 12, 2023
Merged
eitsupi added a commit that referenced this pull request Mar 12, 2023
@eitsupi
chore: install prql-compiler from the latest commit (#104)
eef86dc 
The prql-compiler download fails in the test on macOS in #103, probably
because I specified a commit on a PR from a fork in #101.
This PR switches to installation from the main branch, which should
solve the problem in #103.
@eitsupi eitsupi mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The compile() and prql_to_pl() will freeze if it contains a large number of errors? (from prql-compiler 0.6.0)
2 participants
@eitsupi @max-sixty