Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update AUTHORS format #169

Merged
merged 4 commits into from Sep 2, 2023
Merged

docs: update AUTHORS format #169

merged 4 commits into from Sep 2, 2023

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Sep 2, 2023

Related to #168
Addressing an email received after the first submission of prqlr 0.5.2 (#167).

Thanks, we see:

 person(given = "The authors of the dependency Rust crates", role = c("aut"),
        comment = "see inst/AUTHORS file for details"))

is not acceptable, especially as the file has things like

addr2line (version 0.21.0):
  addr2line authors

anstyle (version 1.0.2):
  anstyle authors

anstyle-parse (version 0.2.1):
  anstyle-parse authors

anstyle-query (version 1.0.0):
  anstyle-query authors

anstyle-wincon (version 1.0.2):
  anstyle-wincon authors

is-terminal (version 0.4.9):
  softprops, Dan Gohman

itertools (version 0.10.5):
  bluss

itertools (version 0.11.0):
  bluss

Please fix and resubmit.

However, looking at the AUTHORS file in the existing packages on CRAN, there does not seem to be a specific format, and I am not sure what format would be accepted by CRAN.

At first, I excluded crates with no package.authors set from the list.

@eitsupi eitsupi added the documentation Improvements or additions to documentation label Sep 2, 2023
@eitsupi eitsupi added this to the v0.5.2 milestone Sep 2, 2023
@eitsupi eitsupi marked this pull request as ready for review September 2, 2023 13:38
@eitsupi eitsupi merged commit 095a3e8 into main Sep 2, 2023
6 checks passed
@eitsupi eitsupi deleted the fix-authors branch September 2, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant