Add random story endpoint #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,11 @@ class Api::StoriesController < Api::BaseController | |||
|
|
|||
| filter_resources_by :series_id, :account_id | |||
|
|
|||
| def random | |||
| @story = Story.published.limit(1).order("RAND()")[0] | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
There was a problem hiding this comment.
can we call first instead of [0]? is that preferable or not? Not sure.
|
@eveadele happy to merge once you address the hound comments and my own. @kookster see anything you're concerned about here? I think it's a reasonable standard to set, potentially with a similar interface for accounts. I do wonder whether this justifies another link, though I am not clear how we would want to encode it. |
|
|
||
| collection do | ||
| get 'random', to: 'stories#random' | ||
| end |
There was a problem hiding this comment.
seems like the to: is unnecessary, perhaps just this?
get 'random', on: :collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'api/v1/stories/random' selects a random published story. The Category Recorder app relies on this feature.