Simplify stimulus verbiage in date controller

PRX · Apr 21, 2023 · 2686e2f · 2686e2f
1 parent fb5b9f4
commit 2686e2f
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/app/javascript/controllers/date_controller.js b/app/javascript/controllers/date_controller.js
@@ -23,14 +23,14 @@ export default class extends Controller {
         this.element.classList.remove("bg-danger")
       }
       event.target.classList.remove("bg-primary", "text-light")
-      event.target.firstElementChild.setAttribute("disabled", true)
+      event.target.firstElementChild.disabled = true
     } else {
       if (this.isDraft(event.target.firstElementChild)) {
         event.target.classList.add("bg-danger", "text-light")
       } else {
         event.target.classList.add("bg-primary", "text-light")
       }
-      event.target.firstElementChild.removeAttribute("disabled")
+      event.target.firstElementChild.disabled = null
     }
   }
 
@@ -58,7 +58,7 @@ export default class extends Controller {
   }
 
   isDisabled(el) {
-    return el.getAttribute("disabled") === "true" || el.getAttribute("disabled") === "disabled"
+    return el.disabled === true
   }
 
   isDraft(el) {

diff --git a/app/javascript/controllers/pager_controller.js b/app/javascript/controllers/pager_controller.js
@@ -3,13 +3,13 @@ import { Controller } from "@hotwired/stimulus"
 export default class extends Controller {
   static targets = ["page", "prev", "next"]
   static values = {
-    currentPosition: {type: Number, default: 0},
-    range: {type: Number, default: 6},
-    step: {type: Number, default: 1}
+    currentPosition: { type: Number, default: 0 },
+    range: { type: Number, default: 6 },
+    step: { type: Number, default: 1 },
   }
 
   currentPositionValueChanged() {
-    this.pageTargets.forEach(el => {
+    this.pageTargets.forEach((el) => {
       if (this.inRange(parseInt(el.getAttribute("index")))) {
         el.classList.remove("d-none")
       } else {

diff --git a/app/views/podcast_planner/_calendar.html.erb b/app/views/podcast_planner/_calendar.html.erb
@@ -1,4 +1,4 @@
-<div class="col <%= "d-none" if index >= range %>" data-pager-target="page" index=<%= index %>>
+<div class="col <%= "d-none" if index >= range %>" data-pager-target="page" index="<%= index %>">
   <%= month_calendar(start_date: start_date) do |date| %>
     <% if date_is_in_month?(date, start_date.month) %>
       <%= date.day %>

diff --git a/app/views/podcast_planner/_form_side.html.erb b/app/views/podcast_planner/_form_side.html.erb
@@ -29,11 +29,11 @@
         <div class="col-lg">
           <div data-controller="pager" data-pager-range-value="6">
             <div class="mb-2">
-              <%= button_tag type: "button", class: "btn btn-primary btn-sm", data: { action: "click->pager#pageBackward", pager_target: "prev" }, disabled: true do %>
+              <%= button_tag type: "button", class: "btn btn-primary btn-sm", data: {action: "click->pager#pageBackward", pager_target: "prev"}, disabled: true do %>
                 <span class="material-icons">arrow_left</span>
                 Month
               <% end %>
-              <%= button_tag type: "button", class: "btn btn-primary btn-sm", data: { action: "click->pager#pageForward", pager_target: "next" } do %>
+              <%= button_tag type: "button", class: "btn btn-primary btn-sm", data: {action: "click->pager#pageForward", pager_target: "next"} do %>
                 Month
                 <span class="material-icons">arrow_right</span>
               <% end %>