Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID3 data #771

Closed
2 tasks done
Tracked by #781
cavis opened this issue Aug 15, 2023 · 3 comments
Closed
2 tasks done
Tracked by #781

ID3 data #771

cavis opened this issue Aug 15, 2023 · 3 comments
Labels
high

Comments

@cavis
Copy link
Member

cavis commented Aug 15, 2023 •
edited

Currently, we copy ID3 data from the 1st segment. But now there are some tricks. Research and decide what to do.

  • What about non-mp3 uploads? Do we support metadata on flac/wav?
  • What about splitting audio files - is ID3 maintained throughout that?
@cavis cavis mentioned this issue Aug 15, 2023
Closed
@cavis cavis added the high label Aug 21, 2023
@cavis
Copy link
Member Author

cavis commented Sep 15, 2023 •
edited

Okay, so currently the cdn-arranger will:

  • Successfully pull Vorbis tags + images off a flac file
  • Successfully pull Info tags off a wav file
  • Failed to pull ID3 tags off a wav file (is this even a thing? I found an app that let me do it).
  • Successfully pull Vorbis images from an ogg file ... but failed to pull tags for some reason?

So support seems spotty at best.

@cavis
Copy link
Member Author

cavis commented Sep 15, 2023

When segmenting any file, we drop the metadata at the moment. Should probably keep that, at least on the first file.

@cavis
Copy link
Member Author

cavis commented Sep 20, 2023

Closing this research - #841 is the fix for this epic. And #842 is the longer term plan.

@cavis cavis closed this as completed Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cavis