-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/apple feed subclass #1013
Feat/apple feed subclass #1013
Conversation
@@ -0,0 +1,5 @@ | |||
class Feed::AppleSubscriptionPolicy < ApplicationPolicy | |||
def show? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe could leave this out until UI PR? i think this got added in a commit before realizing which branch i was in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep - I think you can delete this. You shouldn't need it at all, since you set self.model_name
to Feed in the model. That causes the child-model to use the policy of the parent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm liking the direction of this! A couple comments/gotchas (mostly trying to untangle some existing logic/rules).
But I think this will be a good direction to go in!
@@ -0,0 +1,5 @@ | |||
class Feed::AppleSubscriptionPolicy < ApplicationPolicy | |||
def show? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep - I think you can delete this. You shouldn't need it at all, since you set self.model_name
to Feed in the model. That causes the child-model to use the policy of the parent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good to me!
adds a
Feed::AppleSubscription
subclass in preparation for Apple Subscription UI work.