#606: Podcast Planner verbiage and spacing updates #610
Conversation
| @@ -1,7 +1,7 @@ | |||
| <section> | |||
| <div class="mb-4"> | |||
| <h2 class="fw-bold"><%= t(".header.date_calculation") %></h2> | |||
| <p><%= t(".help.date_calculation") %></p> | |||
| <p class="lh-sm"><%= t(".help.date_calculation") %></p> | |||
There was a problem hiding this comment.
The line-height felt too big
| @@ -20,22 +20,19 @@ | |||
| <p><%= t(".help.week_select") %></p> | |||
| <div class="row"> | |||
| <div class="col-lg-6"> | |||
| <p><%= t(".help.calculate_weeks") %></p> | |||
There was a problem hiding this comment.
I moved some of this verbiage to the field itself. While trying to finding the right word, I found it to be a little redundant. I think its cleaner this way.
Open to discussion.
| @@ -9,19 +9,18 @@ | |||
| method: :post | |||
| ) do |form| %> | |||
| <div class="card-body"> | |||
| <div class="col mb-2"> | |||
| <h3 class="fw-bold"><%= t(".header.publish_time") %></h3> | |||
| <div class="mb-4"> | |||
There was a problem hiding this comment.
The fields didn't need to be in their own column. The spacer works here.
| <div class="form-floating"> | ||
| <%= form.number_field :segment_count, {min: 1, max: 10, step: 1, value: 2} %> | ||
| <%= form.label :segment_count %> | ||
| <%= form.label t(".header.segment_count") %> | ||
| <button type="button" class="help-text" data-bs-toggle="popover" data-bs-content="<%= t(".header.help.segment_count") %>"><span class="material-icons">help</span></button> |
There was a problem hiding this comment.
I was hoping to change "segment count" to "number of Segments" to match the episode form. Hopefully this works.
Also imported the help text from the episode form for this field.
| @@ -228,7 +228,7 @@ en: | |||
| success: Episode drafts generated. | |||
| form_main: | |||
| header: Plan Episodes | |||
| help_html: Save yourself some time by automatically creating multiple episode drafts to create a production schedule, it may also help your revenue as our sales teams will have access to dropdates to sell against. If you only wish to add a single episode, <a href="%{url}">go here</a>. | |||
| help_html: Add multiple episode drafts to create a production schedule. Episode drafts improve the accuracy of your podcast's forecasts. If you only need to add a single episode, <a href="%{url}">go here</a>. | |||
There was a problem hiding this comment.
Brevity! LMK your thoughts!
|
@radical-ube I hope these changes are okay! Once I took a deeper look I have a few suggestions. Happy to discuss any of them. Feedback is a gift cc: @cavis |
|
Closing without merging. Will start over in a new PR to account for changes in #613 |
closes #606