Sort Dropdown Fixes #621
Merged
Sort Dropdown Fixes #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavis
approved these changes
Apr 25, 2023
|
|
||
| DEFAULT_PAGE_SIZE = 10 | ||
|
|
||
| # GET /podcasts | ||
| def index | ||
| base_query = policy_scope(Podcast).page(params[:page]).per(DEFAULT_PAGE_SIZE).includes(default_feed: :feed_images) | ||
| @podcasts = add_sorting(base_query).filter_by_title(params[:q]) | ||
| filtered_podcasts = base_query.filter_by_title(params[:q]) | ||
| @podcasts = add_sorting(filtered_podcasts) |
There was a problem hiding this comment.
Noting this change is functionally equivalent to what was there before. (Calling both add_sorting and .filter_by_title on the base query, assigning the result to @podcasts). But this is fine, if you think it's more readable this way.
There was a problem hiding this comment.
The latter way would maybe be easier for me to come back and understand what's happening, but I'm not insistent about it. I can change it back to the way it was before.
app/views/podcasts/index.html.erb
Outdated
| <li><%= link_to "# of Episodes", podcasts_path(sort: "episode_count"), class: "dropdown-item" %></li> | ||
| <li><%= link_to "A-Z", podcasts_path(sort: "A-Z"), class: "dropdown-item" %></li> | ||
| <li><%= link_to "Z-A", podcasts_path(sort: "Z-A"), class: "dropdown-item" %></li> | ||
| <li><%= active_link_to "Recent Activity", podcasts_path(sort: "Recent Activity"), active: :exact, class: "dropdown-item text-decoration-none" %></li> |
There was a problem hiding this comment.
I think these should stay indented, inside the <ul>?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #597