Podcast Planner verbiage and layout #628
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { Controller } from "@hotwired/stimulus" | ||
|
|
||
| export default class extends Controller { | ||
| static targets = ["counter", "display"] | ||
| static values = { | ||
| selected: { type: Number, default: 0 } | ||
| } | ||
|
|
||
| connect() { | ||
| this.selectedValue = this.countSelectedTargets() | ||
| this.displayTarget.innerHTML = this.selectedValue | ||
| } | ||
|
|
||
| recount() { | ||
| this.selectedValue = this.countSelectedTargets() | ||
| this.displayTarget.innerHTML = this.selectedValue | ||
| } | ||
|
|
||
| countSelectedTargets() { | ||
radical-ube marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| const selectedTargets = this.counterTargets.filter(el => { | ||
| return el.firstElementChild.disabled | ||
| }) | ||
| return this.counterTargets.length - selectedTargets.length | ||
|
There was a problem hiding this comment. Naming is a bit misleading ... |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,56 +1,53 @@ | ||
| <%= form_with( | ||
| url: podcast_planner_path(@podcast), | ||
| method: :post | ||
| ) do |form| %> | ||
| <div class="mb-4"> | ||
| <h3 class="mb-3"><%= t(".header.publish_time") %></h3> | ||
| <div class="col-lg-12"> | ||
| <div class="form-floating"> | ||
| <%= form.select :publish_time, time_options %> | ||
| <%= form.label :publish_time %> | ||
| </div> | ||
| </div> | ||
|
There was a problem hiding this comment. This file was reworked since its no longer technically a sidebar card There was a problem hiding this comment. Functionally there shouldn't be any different. All presentational here. |
||
| </div> | ||
|
|
||
| <div class="mb-4"> | ||
| <h3 class="mb-3"><%= t(".header.audio_segments") %></h3> | ||
| <div class="col-lg-12"> | ||
| <div class="form-floating"> | ||
| <%= form.number_field :segment_count, {min: 1, max: 10, step: 1, value: 2} %> | ||
| <%= form.label :segment_count %> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="card p-4 mt-4mb-4"> | ||
| <%= turbo_frame_tag "preview", target: "_top" do %> | ||
|
There was a problem hiding this comment. moved turbo_frame up here so that the count display will update when the calculator changes selections. |
||
| <div data-controller="pager count" data-pager-range-value="6"> | ||
| <div class="d-flex justify-content-between"> | ||
| <h3 class="mb-3"><%= t(".header.number_of_drafts") %> | ||
| <span data-count-target="display"></span> | ||
radical-ube marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| </h3> | ||
| <div class="mb-2"> | ||
| <%= button_tag type: "button", class: "btn btn-primary btn-sm", data: {action: "click->pager#pageBackward", pager_target: "prev"}, disabled: true do %> | ||
| <span class="material-icons">arrow_left</span> | ||
| Month | ||
| <% end %> | ||
| <%= button_tag type: "button", class: "btn btn-primary btn-sm", data: {action: "click->pager#pageForward", pager_target: "next"} do %> | ||
| Month | ||
| <span class="material-icons">arrow_right</span> | ||
| <% end %> | ||
| </div> | ||
| </div> | ||
| <div class="row"> | ||
| <% 24.times do |i| %> | ||
| <%= render "calendar", form: form, start_date: Date.today.beginning_of_month + i.months, planner: @planner, index: i, range: 6 %> | ||
| <% end %> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <% end %> | ||
| </div> | ||
| <%= form.submit t(".label.submit"), class: "btn btn-primary mb-4" %> | ||
| <% end %> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,6 @@ | ||
| <%= render "podcasts/tabs" %> | ||
|
|
||
| <div class="my-4 px-2"> | ||
| <%= render "form_main" %> | ||
| <%= render "form_side" %> | ||
| </div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this and the
counterTargetbelow are additions for the new stimuluscount_controller. Essentially adds a counter to each date. the controller counts the ones that are selected.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved
counterTargetto the input in the_calendarpartial.