Ignore when no kinesis stream set (useful for dev server)

PRX · May 3, 2019 · ef85a31 · ef85a31
1 parent 4e99497
commit ef85a31
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/kinesis.js b/lib/kinesis.js
@@ -15,5 +15,10 @@ exports.put = async function(json) {
     StreamName = StreamName.split('/').pop()
   }
 
-  await kinesis.putRecord({Data, PartitionKey, StreamName}).promise()
+  if (StreamName) {
+    await kinesis.putRecord({Data, PartitionKey, StreamName}).promise()
+    return true
+  } else {
+    return false
+  }
 }
diff --git a/lib/kinesis.test.js b/lib/kinesis.test.js
@@ -6,6 +6,8 @@ const kinesis = require('./kinesis')
 
 describe('kinesis', () => {
 
+  beforeEach(() => process.env.KINESIS_STREAM = 'test-stream')
+
   it('puts data to kinesis', async () => {
     await kinesis.put({foo: 'bar'})
     expect(sdk.__kinesisPuts.length).toEqual(1)
@@ -30,6 +32,12 @@ describe('kinesis', () => {
     expect(sdk.__kinesisPuts[0].StreamName).toEqual('anything')
   })
 
+  it('ignores puts with no stream set', async () => {
+    process.env.KINESIS_STREAM = ''
+    await kinesis.put({foo: 'bar'})
+    expect(sdk.__kinesisPuts.length).toEqual(0)
+  })
+
   it('decodes kinesis stream arns', async () => {
     process.env.KINESIS_STREAM = 'arn:aws:kinesis:us-east-1:12345678:stream/anything'
     await kinesis.put({foo: 'bar'})