Bugfix: maintain dashes and case during scope arithmetic #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavis
approved these changes
Aug 11, 2020
|
|
||
| it 'maintains dashes and capitalization in the result' do | ||
| sl = new_list('The-Beginning the-middle the-end') - new_list('the-Middle') | ||
| assert sl.to_s == 'The-Beginning the-end' |
There was a problem hiding this comment.
Ah, so is this why tokens now have read_private in their "scope" instead of read-private? Not that we ever look for those anyways.
There was a problem hiding this comment.
yeah, that's why (though they are equivalent for the purposes of checking if a scope is present in a token, the string representation is different so pulling a list in tests was slightly more of a pain).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily aesthetic, since code that checks for scopes should never be looking at string values directly, but having this work this way would have made some tests I have been writing much easier.