Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow checking for expired tokens using both old and normative format #27

Merged
merged 3 commits into from
Sep 8, 2020
Merged

Allow checking for expired tokens using both old and normative format #27

merged 3 commits into from
Sep 8, 2020

Conversation

cqr
Copy link
Contributor

@cqr cqr commented Aug 31, 2020 •
edited

@cqr cqr requested a review from cavis August 31, 2020 15:32
cavis
cavis requested changes Aug 31, 2020
View reviewed changes
Copy link
Member

@cavis cavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing about readability ... otherwise looks good!

lib/rack/prx_auth.rb Outdated Show resolved Hide resolved
test/rack/prx_auth_test.rb Outdated Show resolved Hide resolved
test/rack/prx_auth_test.rb Outdated Show resolved Hide resolved
@cqr cqr requested a review from cavis September 8, 2020 11:38
cavis
cavis approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@cavis cavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+10:

@cavis cavis merged commit 17f0826 into master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cavis cavis cavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cqr @cavis