Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Bicep version 0.5.6 #29

Closed
wants to merge 3 commits into from
Closed

Support for Bicep version 0.5.6 #29

wants to merge 3 commits into from

Conversation

PalmEmanuel
Copy link
Member

Solves PSBicep/BicepNet#28

No real changes needed from my manual testing, other than version bumps. Have not tried with a public registry, but previous functionality seems fine.

@PalmEmanuel
Copy link
Member Author

Accidentally pushed the changes from #25 as well.

@StefanIvemo
Copy link
Member

Awesome!🚀

bjompen
bjompen previously approved these changes Apr 14, 2022
@StefanIvemo
Copy link
Member

Get an issue with Find-BicepNetModule. Get an error when my modules have multiple versions.

Using this PR:
image

Using BicepNet 2.0.2
image

@StefanIvemo
Copy link
Member

StefanIvemo commented Apr 14, 2022

Curious question, why do we not have the url in the warning message?
image

Note: the warning comes from build

@StefanIvemo
Copy link
Member

The built-in bicepconfig.json must be updated to support the public module registry:
image

@PalmEmanuel
Copy link
Member Author

Curious question, why do we not have the url in the warning message?

I think that we probably haven't implemented any logic to do with the linter, since it was added later than when BicepNet was created. I created PSBicep/PSBicep#299 to look into it.

@PalmEmanuel
Copy link
Member Author

Replaced by #31

@PalmEmanuel PalmEmanuel closed this May 5, 2022
@PalmEmanuel PalmEmanuel deleted the v0.5.6 branch May 15, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants