Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter CCC params for C/S #336

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Filter CCC params for C/S #336

merged 1 commit into from
Jan 29, 2021

Conversation

jdebacker
Copy link
Member

This PR adds a filter so that not all the CCC parameters are available on the C/S web app. The reason is two-fold:

  1. Some of the individual income tax rate parameters are redundant on the app since Tax-Calculator is run in each C/S run.
  2. Some parameters, such as those around household savings behavior, are too "in the weeds" and unlikely to be changed by C/S users. Removing them will reduce clutter and confusion on the C/S input page.

@codecov-io
Copy link

codecov-io commented Jan 26, 2021

Codecov Report

Merging #336 (bd834b7) into master (343820b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #336   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1114      1114           
=========================================
  Hits          1114      1114           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jdebacker jdebacker merged commit bfafa14 into PSLmodels:master Jan 29, 2021
@jdebacker jdebacker deleted the cs_rates branch January 29, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants