New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compress large file #688
Compress large file #688
Conversation
@jdebacker. This looks good to me. Is it ready to go from your end? |
@rickecon Yes - the test affected still takes to long for Travis CI, so it's still flagged not to run here. But it did pass locally. But I now see that Travis CI has disappeared here. Shall I include this test in our GH testing suite and see if the GH Action has a timeout limit? |
@jdebacker . Yes. I think we should try to add this test to the GH Action testing and see if it goes through. Testing the tax functions seems like an important check for every PR. Regarding TravisCI, are you saying that it just stopped working? That is weird. But I guess we're OK to just do our testing through GH Actions. |
@jdebacker I found that the GH timeout limit for a job within a workflow is 6 hours. |
Wow! That is great. Thanks for letting us know @chusloj. |
@rickecon There was an issue with running the But we should start to add tests to the suite of tests run in our GH Actions now that we are not using Travis CI. FYI, it looks like Travis CI may still be free for us, but they must have changed something with their API because I noticed that it stopped running on the Cost-of-Captial-Calculator repo last week and OG-USA this week. |
Looks like the |
This PR addressed Issue #623. It does so by compressing the pickle file used in the
test_txfunc.py::test_tax_func_loop
unit test using thebz2
package.Thanks to @chusloj for this suggestion.