Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python version to be <3.12 in setup.py #901

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

rickecon
Copy link
Member

This PR updates the Python version requirements in setup.py to be python_requires=">=3.7.7, <3.12". The new addition is the <3.12 piece. This requirement is in environment.yml. However, when OG-Core is pip installed, it uses setup.py and will sometimes install Python 3.12. The PR makes the Python version always be < 3.12.

cc: @jdebacker

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0866c09) 80.52% compared to head (72ee2bd) 80.52%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #901   +/-   ##
=======================================
  Coverage   80.52%   80.52%           
=======================================
  Files          19       19           
  Lines        4452     4452           
=======================================
  Hits         3585     3585           
  Misses        867      867           
Flag Coverage Δ
unittests 80.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ogcore/__init__.py 100.00% <100.00%> (ø)

@rickecon
Copy link
Member Author

@jdebacker. This PR is ready for review. It is a small change.

@jdebacker
Copy link
Member

Thanks for looking at this @rickecon.

This seems like it relates to Issue #889.

Because it maybe helpful going forward (i.e., making sure OG-Core is compatible with 3.12+), can you document in this PR or that issue what were the problems you noticed with the ogcore package in Python 3.12?

@rickecon
Copy link
Member Author

@jdebacker. I never verified that the errors I was getting in OG-USA were coming from Python 3.12. But the principle is that if we are restricting it in the environment.yml file, we need to also restrict it in the setup.py file.

I think we should lift that restriction or move it to <3.13 as soon as possible. But we should only do that with testing.

@jdebacker jdebacker merged commit 1331b6a into PSLmodels:master Feb 12, 2024
11 checks passed
@rickecon rickecon deleted the python branch February 12, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants