-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update openfisca-uk usage #11
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 51.76% 51.63% -0.14%
==========================================
Files 5 5
Lines 736 736
==========================================
- Hits 381 380 -1
- Misses 355 356 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@jdebacker @rickecon not really sure why this is specifically failing on 3.9? I've only really changed the API specifics, the inputs and outputs to the openfisca code should be identical. Could be an openfisca-uk issue. |
@nikhilwoodruff it's nothing you did. The PR adding openfisca UK also failed 3.9 but was merged before tests completed. I don't know why it fails but you can remove 3.9 from test matrix if you like. I think that's ok since openfisca only tested on 3.7. |
@jdebacker's OpenFisca-UK Integration PR #2 to this repo was passing all tests when I merged it. And |
@nikhilwoodruff @jdebacker. I have reviewed this PR, and it looks good to me. Any further changes from either of you two? |
Thanks @rickecon - nothing further to add here from me. |
OpenFisca-UK just had a considerable update merged, which uses a new interface (to make loading data from different surveys and years much easier, as well as performance improvements). I've adjusted the code here that accesses openfisca-uk to use the new API (largely just syntax changes). A few comments/questions on the pre-existing code, the semantics of which I haven't changed: