Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _ACTC_ChildNum documentation and use it more often in the code #1666

Merged
merged 1 commit into from Nov 16, 2017
Merged

Fix _ACTC_ChildNum documentation and use it more often in the code #1666

merged 1 commit into from Nov 16, 2017

Conversation

martinholmer
Copy link
Collaborator

The changes in this pull request were suggested by @evtedeschi3 in issue #1665.

Hopefully the new documentation is less confusing and certainly the code is more accurately parameterized.
These changes have no effect on current-law tax results, but the more thorough parameterization of the ACTC function could cause reforms that change _ACTC_ChildNum to produce slightly different (and more accurate) results than they did before these changes.

@MattHJensen @feenberg @Amy-Xu @andersonfrailey @hdoupe @codykallen @evtedeschi3

@codecov-io
Copy link

Codecov Report

Merging #1666 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1666   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        2856    2856           
======================================
  Hits         2856    2856

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c36b449...5f995c7. Read the comment docs.

@martinholmer martinholmer merged commit fb17b8e into PSLmodels:master Nov 16, 2017
@martinholmer
Copy link
Collaborator Author

No concerns or comments, so merging pull request #1666, which responds to bug report in issue #1665.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants