Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check of Consumption BEN_*_value parameters #1894

Merged
merged 2 commits into from Feb 24, 2018
Merged

Add check of Consumption BEN_*_value parameters #1894

merged 2 commits into from Feb 24, 2018

Conversation

martinholmer
Copy link
Collaborator

This pull request adds to the Calculator distribution_tables and difference_table methods a check that the two Calculator objects have the same values for the BEN_*_value parameters embedded in their Consumption objects. This test is necessary because the consumption value of non-cash benefits is included in expanded_income. Different values for the BEN_*_value parameters in the baseline and reform Calculator objects would induce a spurious change in both expanded_income and after-tax expanded income.

@martinholmer martinholmer changed the title Add check of Consumption benefit_*_value parameters Add check of Consumption BEN_*_value parameters Feb 23, 2018
@codecov-io
Copy link

codecov-io commented Feb 23, 2018

Codecov Report

Merging #1894 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1894   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        3301    3308    +7     
======================================
+ Hits         3301    3308    +7
Impacted Files Coverage Δ
taxcalc/consumption.py 100% <100%> (ø) ⬆️
taxcalc/calculate.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ca678...e354497. Read the comment docs.

@martinholmer martinholmer merged commit a4472b4 into PSLmodels:master Feb 24, 2018
@martinholmer martinholmer deleted the add-benval-check branch March 7, 2018 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants