Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline logic of create_distribution_table utility and improve tbi fuzzing #1972

Merged
merged 3 commits into from Apr 17, 2018
Merged

Streamline logic of create_distribution_table utility and improve tbi fuzzing #1972

merged 3 commits into from Apr 17, 2018

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Apr 16, 2018

This pull request adds a decile_details argument to the add_quantile_row_table_variable utility function.
The remaining changes all flow from that change:

  1. The logic of the create_distribution_table utility has been considerably simplified and made more accurate.
  2. The fuzzing of distribution table PUF results in the TaxBrain Interface (tbi) has been strengthened by fuzzing each of the subgroups of the bottom and top deciles (rather than fuzzing just the whole bottom decile and the whole top decile).

@codecov-io
Copy link

codecov-io commented Apr 16, 2018

Codecov Report

Merging #1972 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1972   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          38      38           
  Lines        3780    3783    +3     
======================================
+ Hits         3780    3783    +3
Impacted Files Coverage Δ
taxcalc/taxcalcio.py 100% <ø> (ø) ⬆️
taxcalc/utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2c57f...ec6b469. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants