Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise diagnostic table logic making it easier to create when assuming behavioral responses #2126

Merged
merged 5 commits into from Nov 22, 2018
Merged

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Nov 22, 2018

This pull request answers the question posed by @evtedeschi3 in issue #2125. By moving some of the low-level logic of creating multi-year diagnostic tables from the Calculator class to the create_diagnostic_table utility function, it is now easier to create a multi-year diagnostic table when assuming behavioral responses to a policy reform. The new approach, which requires Tax-Calculator 0.23.2 or higher, is illustrated in the expanded Cookbook recipe 2.

The Calculator method diagnostic_table method works exactly as before, so there is no API change there.
However, the signature of the create_diagnostic_table utility function has been changed, so that is a minor API change. Given that most people are using the Calculator method rather than the low-level utility function, we are calling this pull request a "New Feature" rather than an "API Change".

@codecov-io
Copy link

Codecov Report

Merging #2126 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2126      +/-   ##
==========================================
+ Coverage   99.91%   99.91%   +<.01%     
==========================================
  Files          16       16              
  Lines        3512     3518       +6     
==========================================
+ Hits         3509     3515       +6     
  Misses          3        3
Impacted Files Coverage Δ
taxcalc/calculator.py 100% <100%> (ø) ⬆️
taxcalc/utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c079b88...cea15ca. Read the comment docs.

@martinholmer martinholmer merged commit 9c49074 into PSLmodels:master Nov 22, 2018
@martinholmer martinholmer deleted the revise-diag-table branch November 22, 2018 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants