Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dep_credit phaseout logic #2205

Merged
merged 1 commit into from Jan 23, 2019
Merged

Fix dep_credit phaseout logic #2205

merged 1 commit into from Jan 23, 2019

Conversation

martinholmer
Copy link
Collaborator

As part of the first step in validating Tax-Calculator results against TAXSIM-27 results for 2018, we have discovered a bug in the phaseout logic for the dep_credit that became part of current-law policy in 2018. The bug is assuming that the phaseout of the dep_credit begins after the child tax credit is completely phased out. But the Child Tax Credit and Credit for Other Dependents Worksheet on page 6 of 2018 IRS Publication 972 makes it crystal clear that the dep_credit is phased out in exactly the same way as the child tax credit is phased out.

@martinholmer martinholmer merged commit adc8e7c into PSLmodels:master Jan 23, 2019
@codecov-io
Copy link

Codecov Report

Merging #2205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2205   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          12      12           
  Lines        2948    2948           
======================================
  Hits         2948    2948

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e68800...07ccf21. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants