Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytest warnings #2743

Merged
merged 15 commits into from
May 9, 2024
Merged

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented May 8, 2024

Revise code to eliminate warnings generated by pytest.

With the merge of PR #2740 there were 440 pytest warnings.

After the changes in this PR #2743, there are 9 pytest warnings, all of which are generated by the ParamTools package use of the marshmallow package. Because the ParamTools package is not part of the Tax-Calculator project, these nine remaining pytest warnings cannot be eliminated by changes in Tax-Calculator source code.

@martinholmer martinholmer self-assigned this May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (e899e7a) to head (e488de5).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2743   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          13       13           
  Lines        2603     2606    +3     
=======================================
+ Hits         2588     2591    +3     
  Misses         15       15           
Flag Coverage Δ
unittests 99.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
taxcalc/growfactors.py 100.00% <100.00%> (ø)
taxcalc/taxcalcio.py 100.00% <100.00%> (ø)
taxcalc/utils.py 97.80% <100.00%> (+0.01%) ⬆️

@martinholmer martinholmer removed the WIP label May 9, 2024
@martinholmer martinholmer merged commit 4df16eb into PSLmodels:master May 9, 2024
9 checks passed
@martinholmer martinholmer deleted the pytest-warnings branch May 9, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant