Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0 release #2753

Merged
merged 37 commits into from
Jun 5, 2024
Merged

4.0.0 release #2753

merged 37 commits into from
Jun 5, 2024

Conversation

bodiyang
Copy link
Contributor

@bodiyang bodiyang commented May 30, 2024

This PR prepares Tax-Calc 4.0.0 new version release.

please check release.md file for the new features of the model.

duncanhobbs and others added 30 commits September 30, 2021 14:22
Update CDCC rates in reform to be on new scale
Update v4 development branch with latest from master
Sync `v4_development` branch to `master`
@martinholmer
Copy link
Collaborator

@bodiyang, I don't understand why you have submitted PR #2753 when tests are failing.
Please, revise you code so that ALL tests pass on you local computer. Then submit the PR.

@jdebacker jdebacker reopened this May 30, 2024
@jdebacker
Copy link
Member

@martinholmer, please see PR #2753 to better understand what is going on.

@bodiyang Can you make this a draft PR until #2573 is merged?

@martinholmer
Copy link
Collaborator

@jdebacker said:

PR #2753 to better understand what is going on.

There was absolutely no explanation of "what is going on" in that original PR.

@bodiyang bodiyang marked this pull request as draft May 30, 2024 19:02
**This is a major release with changes that make Tax-Calculator incompatible with earlier releases.**

**API Changes**
- Reframewrok of the payroll tax policy parameters: Payroll tax parameters are split into the employer side and employee side ~ `FICA_mc_trt`, `FICA_ss_trt` are replaced by `FICA_mc_trt_employer`, `FICA_mc_trt_employee`, `FICA_ss_trt_employer` and `FICA_ss_trt_employee`. [[#2669](https://github.com/PSLmodels/Tax-Calculator/pull/2669) by Bodi Yang]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Reframework" spelled wrong -- and perhaps use "Apply a new framework for the payroll..."

@jdebacker
Copy link
Member

@bodiyang This branch appears to be just a few changes from master (version numbers, release notes). Can you merge the latest v4_development branch into your 4.0.0-release branch?

@bodiyang
Copy link
Contributor Author

bodiyang commented Jun 4, 2024

@bodiyang This branch appears to be just a few changes from master (version numbers, release notes). Can you merge the latest v4_development branch into your 4.0.0-release branch?

have merge the change from v4_development into 4.0.0-release

@bodiyang bodiyang marked this pull request as ready for review June 4, 2024 15:40
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (e0234b6) to head (cb7b95a).
Report is 16 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2753   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          13       13           
  Lines        2605     2605           
=======================================
  Hits         2590     2590           
  Misses         15       15           
Flag Coverage Δ
unittests 99.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
taxcalc/__init__.py 100.00% <100.00%> (ø)
taxcalc/calculator.py 100.00% <ø> (ø)
taxcalc/parameters.py 100.00% <ø> (ø)

@@ -3,6 +3,20 @@ Release history
Go [here](https://github.com/PSLmodels/Tax-Calculator/pulls?q=is%3Apr+is%3Aclosed)
for a complete commit history.

2024-06-01 Release 4.0.0
------------------------
(last merged pull request is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be #2752

docs/about/releases.md Outdated Show resolved Hide resolved
@bodiyang
Copy link
Contributor Author

bodiyang commented Jun 5, 2024

@jdebacker have update the documentation. current testing failure is from the codecov ~ probably we can have a rerun of the tests

@martinholmer martinholmer reopened this Jun 5, 2024
@martinholmer martinholmer merged commit 5e40363 into PSLmodels:master Jun 5, 2024
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants