Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add File Describing PUF and CPS #173

Merged
merged 2 commits into from
Mar 21, 2018

Conversation

andersonfrailey
Copy link
Collaborator

This PR adds a short markdown file to describe the differences between the PUF and CPS files. It will be linked to on TaxBrain so that users have one easy source to see the difference between the two.

cc @Amy-Xu @MattHJensen

@martinholmer
Copy link
Contributor

@andersonfrailey said the new datasets.md file in taxdata pull request #173 is aimed at TaxBrain users.

If that's the intended audience, why are you pointing them to the (technical and difficult to read) source code?

Why not point them to the appropriate sections of the user documentation instead of the records_variables.json file and the the current_law_policy.json file?

These user documentation links are much easier reading and contain exactly the same information: variables and parameters.

@MattHJensen @Amy-Xu

@andersonfrailey
Copy link
Collaborator Author

Good idea, @martinholmer. Latest commit changes the links.

@andersonfrailey
Copy link
Collaborator Author

If there are no more comments, I'll merge this in the morning.

@martinholmer
Copy link
Contributor

@andersonfrailey said:

If there are no more comments, I'll merge this in the morning.

Yes, do that. I like the documentation.

@MattHJensen
Copy link
Contributor

+1 !

@andersonfrailey andersonfrailey merged commit 3e39686 into PSLmodels:master Mar 21, 2018
@andersonfrailey andersonfrailey deleted the documentation branch June 13, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants