Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorsfinalprep #63

Merged
merged 4 commits into from
Feb 7, 2017

Conversation

andersonfrailey
Copy link
Collaborator

This PR adds the script to create put_factors.csv as discussed in TaxCalc PR #1178 using the logic laid out in TaxData issue #60.

I've also added two pieces of code to stage1.py. One which deletes the unnecessary 2008 column from Stage_I_factors and another to label the index YEAR so that Stage_I_factors.csv can be read in factors_finalprep.py without any issue.

@martinholmer

@martinholmer
Copy link
Contributor

martinholmer commented Feb 6, 2017

@andersonfrailey, Thanks for the quick work in taxdata pull request #63. Just two things:

Does dropping 2008 data in stage1.py leave the stage2/Stage_I_factors.csv OK for Stage 2 work?

I forgot to mention on the phone that the output_filename in the stage1/factors_finalprep.py script should be "grow_factors.csv" (not "puf_factors.csv") because the factors are independent of the sample data (puf or cps). Sorry I forgot to mention that.

@andersonfrailey
Copy link
Collaborator Author

@martinholmer asked:

Does dropping 2008 data in stage1.py leave the stage2/Stage_I_factors.csv OK for Stage 2 work?

Yes. Dropping 2008 will have no effect on stage2.

Latest commit also changes puf_factors.csv to growth_factors.csv

@martinholmer
Copy link
Contributor

@andersonfrailey, Thanks for the work on pull request #63. Please merge #63 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants