Refactor of JuMP's nonlinear API #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced JuMP._Derivatives with MathOptInterface.Nonlinear (MOINL). Updated the OperatorRegistry in eago_optimizer\functions\nonlinear\graph\graph.jl and eago_optimizer\functions\nonlinear\graph\utilities.jl which changes how operators are handled in eago_optimizer\functions\nonlinear\graph\graphs\directed_tree.jl and eago_optimizer\functions\nonlinear\composite_relax\forward_propagation.jl Updated epigraph reformulation in eago_optimizer\parse.jl to work with MOINL Models instead of JuMP Models. Also fixed a few typos.
Added exclusions for constraint types not currently supported by EAGO.
Fixed outdated tests that caused errors or failures.
Removed redundancy for ListOfModelAttributesSet based on jump-dev/MathOptInterface.jl@597f5aa
Updated Julia version to 1.6 for the documentation.
Removed these tests too soon..
RXGottlieb
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced JuMP._Derivatives with MathOptInterface.Nonlinear (MOINL), updated EAGO's OperatorRegistry, modified the epigraph reformulation based on these changes, and fixed outdated tests.